Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8292715: Cleanup Problemlist #9963

Closed
wants to merge 2 commits into from
Closed

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Aug 22, 2022

Cleanup of Problemlist


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9963/head:pull/9963
$ git checkout pull/9963

Update a local copy of the PR:
$ git checkout pull/9963
$ git pull https://git.openjdk.org/jdk pull/9963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9963

View PR using the GUI difftool:
$ git pr show -t 9963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9963.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prsadhuk
Copy link
Contributor Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@prsadhuk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 22, 2022

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the understanding (since you did not say) that you have verified all de-listed tests do pass.

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292715: Cleanup Problemlist

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2022
@prsadhuk
Copy link
Contributor Author

Approved on the understanding (since you did not say) that you have verified all de-listed tests do pass.

Since I listed the mach5 job in the closed PR running all tests both open and closed which has passed so I did not mention explicitly here.

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

Going to push as commit 5a20bc4.
Since your change was applied there have been 131 commits pushed to the master branch:

  • 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 76ee549: 8292329: Enable CDS shared heap for zero builds
  • 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
  • 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
  • 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
  • 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
  • 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
  • d3fed12: 8292864: Remove resourceHash.hpp from header files
  • ... and 121 more: https://git.openjdk.org/jdk/compare/77cd917a97b184871ab2d3325ceb6c53afeca28b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2022
@openjdk openjdk bot closed this Aug 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@prsadhuk Pushed as commit 5a20bc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8292715 branch June 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants