Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292717: Clean up checking of testing requirements in configure #9964

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Aug 22, 2022

I have just moved the code around without changing it, with two exceptions:

  • I have updated the names of the functions to match their new home
  • I have changed the order in configure.ac, so toolchain setup is finished before going on to testing requirements.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292717: Clean up checking of testing requirements in configure

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9964/head:pull/9964
$ git checkout pull/9964

Update a local copy of the PR:
$ git checkout pull/9964
$ git pull https://git.openjdk.org/jdk pull/9964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9964

View PR using the GUI difftool:
$ git pr show -t 9964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9964.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2022

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 22, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292717: Clean up checking of testing requirements in configure

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a17fce7: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • 1ed03d8: 8292226: Prepare make for better Link Time Optimization support

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2022
@magicus
Copy link
Member Author

magicus commented Aug 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

Going to push as commit 16593cf.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c59f9b3: 8287828: Fix so that one can select jtreg test case by ID from make
  • 476c484: 8292656: G1: Remove G1HotCardCache::_use_cache
  • a17fce7: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • 1ed03d8: 8292226: Prepare make for better Link Time Optimization support

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2022
@openjdk openjdk bot closed this Aug 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@magicus Pushed as commit 16593cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the move-test-configure-properly branch August 22, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants