Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211958: Broken links in java.desktop files #998

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 2, 2020

Most of the broken links were fixed already by the JDK-8225368 and JDK-8214817
This change fix just a few.

Also two cleanups are applied:

  • The ../../java/awt/doc-files/ in some cases simplified to doc-files/
  • The html links to the java classes via <a href> replaced by the {@link }

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) (1/9 failed)

Failed test task

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/998/head:pull/998
$ git checkout pull/998

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 2, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@@ -97,9 +97,8 @@ <h3>Basic Usage</h3>
<b>"awt.font.desktophints"</b>
can be used to obtain the rendering hints that best match the desktop settings.

The return value is a
<a href="../../util/Map.html"> Map</a> of
Copy link
Member Author

@mrserb mrserb Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link to Map.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@mrserb The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@@ -156,9 +156,9 @@
* the primary IANA name but is guaranteed to be understood by this VM. For
* common flavors, the pre-defined *HOST {@code DocFlavors} may be used.
* <p>
* See <a href="../../java/lang/package-summary.html#charenc">character
Copy link
Member Author

@mrserb mrserb Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link to the java.base module

@openjdk openjdk bot added 2d i18n awt labels Nov 2, 2020
@mrserb mrserb marked this pull request as ready for review Nov 2, 2020
@openjdk openjdk bot added the rfr label Nov 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 2, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211958: Broken links in java.desktop files

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 3302d3a: 8255544: Create a checked cast
  • 54c8813: 8255734: VM should ignore SIGXFSZ on ppc64, s390 too
  • ceab9f3: 6816284: Notepad class should be public
  • eb66418: 7124397: [macosx] JSpinner serialiazation - deserialization issue
  • 79a010f: 8255697: LogTargetHandle::print should check if log level is enabled
  • 98c91b6: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos
  • e97809d: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos
  • 69f5235: 8255596: Mutex safepoint checking options and flags should be scoped enums
  • d05df7c: 8236842: Surprising 'multiple elements' behaviour from getTypeElement when cross-compiling with --release

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 2, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 2, 2020

/integrate

@openjdk openjdk bot closed this Nov 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@mrserb Since your change was applied there have been 24 commits pushed to the master branch:

  • bc6085b: 8255578: [JVMCI] be more careful about reflective reads of Class.componentType.
  • 05bcd67: 8255529: Remove unused methods from java.util.zip.ZipFile
  • d93e3a7: 8255760: Shenandoah: match constants style in ShenandoahMarkTask fallback
  • 3e89f72: 8255237: ZGC: Bulk free garbage pages during relocation set selection
  • 6dac8d2: 8255671: Bidi.reorderVisually has misleading exception messages
  • 2f7d34f: 8255616: Disable AOT and Graal in Oracle OpenJDK
  • 0e19ded: 8255401: Shenandoah: Allow oldval and newval registers to overlap in cmpxchg_oop()
  • a3aad11: 8255400: Shenandoah: C2 failures after JDK-8255000
  • 1769c48: 8255471: ZGC: Rework root iterators and closures
  • b028074: 8255673: Wrong version in docs bundles
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/64feeab70af61a52ffe4c64df87a33c16754de18...master

Your commit was automatically rebased without conflicts.

Pushed as commit acb5f65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8211958 branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d awt i18n integrated
2 participants