-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292790: Remove hashtable.hpp from other files #9986
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
(I tested a battery of hotspot cross-compilation tests, without failures).
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for testing Aleksey and the review Harold. Our internal tests passed. The GHAs are taking longer. I guess I'll wait an hour. |
This is never going to finish but builds everywhere here. |
Going to push as commit fe0544f.
Your commit was automatically rebased without conflicts. |
These includes are no longer needed or haven't been needed for a while. Tested arm cross-compile, and tier1 with Oracle platforms in progress, also GHA. Please review this change which is trivial if the test results are clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9986/head:pull/9986
$ git checkout pull/9986
Update a local copy of the PR:
$ git checkout pull/9986
$ git pull https://git.openjdk.org/jdk pull/9986/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9986
View PR using the GUI difftool:
$ git pr show -t 9986
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9986.diff