8292494: Ensure SystemDictionary::set_platform_loader and set_system_loader are called only once

[calvinccheung]

The SystemDictionary::set_platform_loader and the SystemDictionary::set_system_loader functions should only be called once during VM startup, this simple fix ensures that.

Passed mach5 tiers 1,2,3 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292494: Ensure SystemDictionary::set_platform_loader and set_system_loader are called only once

Reviewers

• Ioi Lam (@iklam - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9988/head:pull/9988
$ git checkout pull/9988

Update a local copy of the PR:
$ git checkout pull/9988
$ git pull https://git.openjdk.org/jdk pull/9988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9988

View PR using the GUI difftool:
$ git pr show -t 9988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9988.diff

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (4a36f560)

[iklam]

Looks good and trivial. Thanks for fixing this.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292494: Ensure SystemDictionary::set_platform_loader and set_system_loader are called only once

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• 76ee549: 8292329: Enable CDS shared heap for zero builds
• 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
• 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
• 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
• 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
• 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
• c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
• a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
• d3fed12: 8292864: Remove resourceHash.hpp from header files
• ... and 20 more: https://git.openjdk.org/jdk/compare/27af0144ea57e86d9b81c2b328fad66e4a046f61...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good!

Thanks

[calvinccheung]

Thanks @iklam, @dholmes-ora .

/integrate

[openjdk]

Going to push as commit 88af204.
Since your change was applied there have been 34 commits pushed to the master branch:

• 8d3d439: 8292903: enhance round_up_power_of_2 assertion output
• 054c23f: 8290025: Remove the Sweeper
• dc7e256: 8290376: G1: Refactor G1MMUTracker::when_sec
• 5a20bc4: 8292715: Cleanup Problemlist
• 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• 76ee549: 8292329: Enable CDS shared heap for zero builds
• 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
• 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
• 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
• 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
• ... and 24 more: https://git.openjdk.org/jdk/compare/27af0144ea57e86d9b81c2b328fad66e4a046f61...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 88af204.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.