Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292739: Invalid legacy entries may be returned by Provider.getServices() call #9992

Closed
wants to merge 1 commit into from

Conversation

valeriepeng
Copy link

@valeriepeng valeriepeng commented Aug 24, 2022

Invalid legacy services are screened and removed in Provider.getService(...) call. This fix is to also screen and remove the invalid legacy services when Provider.getServices() is called.

Leveraged existing test case to test this particular scenario by adding one invalid legacy registration.

Thanks!
Valerie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292739: Invalid legacy entries may be returned by Provider.getServices() call

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9992/head:pull/9992
$ git checkout pull/9992

Update a local copy of the PR:
$ git checkout pull/9992
$ git pull https://git.openjdk.org/jdk pull/9992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9992

View PR using the GUI difftool:
$ git pr show -t 9992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9992.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2022

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 24, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292739: Invalid legacy entries may be returned by Provider.getServices() call

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
  • d3fed12: 8292864: Remove resourceHash.hpp from header files
  • b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable
  • 0813a47: 8282729: Serial: Move BOT implementation to collector specific directory
  • fa5cc4c: 8291878: NMT: Malloc limits
  • ad2e0c4: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 13c0369: 8242181: [Linux] Show source information when printing native stack traces in hs_err files
  • fe0544f: 8292790: Remove hashtable.hpp from other files
  • ... and 2 more: https://git.openjdk.org/jdk/compare/d24b7b7026cf85f1aecf44f60819762872cfd5c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2022
@valeriepeng
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

Going to push as commit 14623c6.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
  • 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
  • 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
  • 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
  • d3fed12: 8292864: Remove resourceHash.hpp from header files
  • b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable
  • 0813a47: 8282729: Serial: Move BOT implementation to collector specific directory
  • fa5cc4c: 8291878: NMT: Malloc limits
  • ... and 5 more: https://git.openjdk.org/jdk/compare/d24b7b7026cf85f1aecf44f60819762872cfd5c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2022
@openjdk openjdk bot closed this Aug 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@valeriepeng Pushed as commit 14623c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@valeriepeng valeriepeng deleted the JDK-8292739 branch August 24, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants