Skip to content

Commit 09f3707

Browse files
committed
8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream
Backport-of: 97e1657
1 parent 1f6eb0f commit 09f3707

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,7 @@ C2V_VMENTRY(jobject, iterateFrames, (JNIEnv*, jobject compilerToVM, jobjectArray
10401040
jobjectArray methods = initial_methods;
10411041

10421042
int frame_number = 0;
1043-
vframe* vf = vframe::new_vframe(fst.current(), fst.register_map(), thread);
1043+
vframe* vf = vframe::new_vframe(fst, thread);
10441044

10451045
while (true) {
10461046
// look for the given method
@@ -1149,7 +1149,7 @@ C2V_VMENTRY(jobject, iterateFrames, (JNIEnv*, jobject compilerToVM, jobjectArray
11491149
if (fst.current()->sp() != stack_pointer) {
11501150
THROW_MSG_NULL(vmSymbols::java_lang_IllegalStateException(), "stack frame not found after deopt")
11511151
}
1152-
vf = vframe::new_vframe(fst.current(), fst.register_map(), thread);
1152+
vf = vframe::new_vframe(fst, thread);
11531153
if (!vf->is_compiled_frame()) {
11541154
THROW_MSG_NULL(vmSymbols::java_lang_IllegalStateException(), "compiled stack frame expected")
11551155
}
@@ -1176,7 +1176,7 @@ C2V_VMENTRY(jobject, iterateFrames, (JNIEnv*, jobject compilerToVM, jobjectArray
11761176
break;
11771177
}
11781178
fst.next();
1179-
vf = vframe::new_vframe(fst.current(), fst.register_map(), thread);
1179+
vf = vframe::new_vframe(fst, thread);
11801180
frame_number = 0;
11811181
} // end of frame loop
11821182

src/hotspot/share/runtime/vframe.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,14 @@ vframe::vframe(const frame* fr, JavaThread* thread)
5959
_fr = *fr;
6060
}
6161

62+
vframe* vframe::new_vframe(StackFrameStream& fst, JavaThread* thread) {
63+
if (fst.current()->is_runtime_frame()) {
64+
fst.next();
65+
}
66+
guarantee(!fst.is_done(), "missing caller");
67+
return new_vframe(fst.current(), fst.register_map(), thread);
68+
}
69+
6270
vframe* vframe::new_vframe(const frame* f, const RegisterMap* reg_map, JavaThread* thread) {
6371
// Interpreter frame
6472
if (f->is_interpreted_frame()) {

src/hotspot/share/runtime/vframe.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -60,8 +60,9 @@ class vframe: public ResourceObj {
6060
vframe(const frame* fr, const RegisterMap* reg_map, JavaThread* thread);
6161
vframe(const frame* fr, JavaThread* thread);
6262
public:
63-
// Factory method for creating vframes
63+
// Factory methods for creating vframes
6464
static vframe* new_vframe(const frame* f, const RegisterMap *reg_map, JavaThread* thread);
65+
static vframe* new_vframe(StackFrameStream& fst, JavaThread* thread);
6566

6667
// Accessors
6768
frame fr() const { return _fr; }

0 commit comments

Comments
 (0)