-
Notifications
You must be signed in to change notification settings - Fork 235
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8268362: [REDO] C2 crash when compile negative Arrays.copyOf length a…
…fter loop Backport-of: 22ebd19
- Loading branch information
1 parent
8008d33
commit 2252165
Showing
7 changed files
with
227 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
test/hotspot/jtreg/compiler/arraycopy/TestNegArrayLengthAsIndex1.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright (C) 2021 THL A29 Limited, a Tencent company. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/** | ||
* @test | ||
* @bug 8268362 | ||
* @requires vm.compiler2.enabled & vm.debug | ||
* @summary C2 using negative array length as index, using a.length. | ||
* AllocateArrayNode::make_ideal_length create CastIINode to not negative range. | ||
* Apply transform in GraphKit::load_array_length will covert array load index type to top. | ||
* This cause assert in Parse::array_addressing, it expect index type is int. | ||
* @run main/othervm -XX:-PrintCompilation compiler.arraycopy.TestNegArrayLengthAsIndex1 | ||
*/ | ||
|
||
package compiler.arraycopy; | ||
public class TestNegArrayLengthAsIndex1 { | ||
|
||
public static void main(String[] args) throws Exception { | ||
for (int i = 0; i < 10000; i++) { | ||
foo(); | ||
} | ||
} | ||
|
||
static int foo() { | ||
int minusOne = -1; | ||
int[] a = null; | ||
try { | ||
a = new int[minusOne]; | ||
} catch (NegativeArraySizeException e) { | ||
return 0; | ||
} | ||
return a[a.length - 1]; | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
test/hotspot/jtreg/compiler/arraycopy/TestNegArrayLengthAsIndex2.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright (C) 2021 THL A29 Limited, a Tencent company. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/** | ||
* @test | ||
* @bug 8268362 | ||
* @requires vm.compiler2.enabled & vm.debug | ||
* @summary C2 using negative array length as index, using array allocation length. | ||
* This assertion is triggered by 8267904. | ||
* @run main/othervm compiler.arraycopy.TestNegArrayLengthAsIndex2 | ||
*/ | ||
|
||
package compiler.arraycopy; | ||
public class TestNegArrayLengthAsIndex2 { | ||
|
||
public static void main(String[] args) throws Exception { | ||
for (int i = 0; i < 10000; i++) { | ||
foo(); | ||
} | ||
} | ||
|
||
static int foo() { | ||
int minusOne = -1; | ||
int[] a = null; | ||
try { | ||
a = new int[minusOne]; | ||
} catch (NegativeArraySizeException e) { | ||
return 0; | ||
} | ||
return a[minusOne - 1]; | ||
} | ||
} |
60 changes: 60 additions & 0 deletions
60
test/hotspot/jtreg/compiler/arraycopy/TestNegativeArrayCopyAfterLoop.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* Copyright (C) 2021 THL A29 Limited, a Tencent company. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/** | ||
* @test | ||
* @bug 8267904 | ||
* @requires vm.compiler2.enabled | ||
* @summary C2 inline array_copy move CastIINode(Array Length) before allocation cause crash. | ||
* @run main/othervm compiler.arraycopy.TestNegativeArrayCopyAfterLoop | ||
*/ | ||
|
||
package compiler.arraycopy; | ||
import java.util.Arrays; | ||
|
||
class test { | ||
public static int exp_count = 0; | ||
public int in1 = -4096; | ||
test (){ | ||
try { | ||
short sha4[] = new short[1012]; | ||
for (int i = 0; i < sha4.length; i++) { | ||
sha4[i] = 9; | ||
} | ||
Arrays.copyOf(sha4, in1); | ||
} catch (Exception ex) { | ||
exp_count++; | ||
} | ||
} | ||
} | ||
|
||
public class TestNegativeArrayCopyAfterLoop { | ||
public static void main(String[] args) { | ||
for (int i = 0; i < 20000; i++) { | ||
new test(); | ||
} | ||
if (test.exp_count == 20000) { | ||
System.out.println("TEST PASSED"); | ||
} | ||
} | ||
} |
2252165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues