Skip to content

Commit

Permalink
8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: …
Browse files Browse the repository at this point in the history
…bad address

Backport-of: abe532a89cbdd2b959789611cecbad7c94f6a870
  • Loading branch information
GoeLin committed Jan 17, 2023
1 parent 6c3d4df commit 8dd8122
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/hotspot/cpu/aarch64/aarch64.ad
Expand Up @@ -3114,7 +3114,8 @@ encode %{
__ mov_metadata(dst_reg, (Metadata*)con);
} else {
assert(rtype == relocInfo::none, "unexpected reloc type");
if (con < (address)(uintptr_t)os::vm_page_size()) {
if (! __ is_valid_AArch64_address(con) ||
con < (address)(uintptr_t)os::vm_page_size()) {
__ mov(dst_reg, con);
} else {
uint64_t offset;
Expand Down
57 changes: 57 additions & 0 deletions test/hotspot/jtreg/compiler/unsafe/TestBadBaseAddress.java
@@ -0,0 +1,57 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8296924
* @summary Tests compilation of an unreachable unsafe access with a bad base address.
* @modules java.base/jdk.internal.misc:+open
* @run main/othervm -XX:CompileCommand=compileonly,TestBadBaseAddress::test -XX:-TieredCompilation -Xcomp TestBadBaseAddress
*/

import java.lang.reflect.*;
import sun.misc.*;

public class TestBadBaseAddress {
private static Unsafe unsafe;

static {
try {
Field field = Unsafe.class.getDeclaredField("theUnsafe");
field.setAccessible(true);
unsafe = (Unsafe)field.get(null);
} catch (Exception e) {
throw new RuntimeException(e);
}
}

public static void test(boolean b) {
if (b) {
unsafe.putLong(-1, 42);
}
}

public static void main(String[] args) {
test(false);
}
}

1 comment on commit 8dd8122

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.