Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
8274714: Incorrect verifier protected access error message
Backport-of: e39bdc9ddb7ba50160d07a27e6038cdea6a594a8
- Loading branch information
Showing
3 changed files
with
104 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
test/hotspot/jtreg/runtime/verifier/PutfieldProtectedTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8274714 | ||
* @summary Make sure error message for protected putfield error is correct. | ||
* @compile putfieldProtected.jasm | ||
* @run main/othervm -Xverify:remote PutfieldProtectedTest | ||
*/ | ||
|
||
// Test that an int[] is not assignable to byte[]. | ||
public class PutfieldProtectedTest { | ||
|
||
public static void main(String args[]) throws Throwable { | ||
try { | ||
Class newClass = Class.forName("other.putfieldProtected"); | ||
throw new RuntimeException("Expected VerifyError exception not thrown"); | ||
} catch (java.lang.VerifyError e) { | ||
if (!e.getMessage().contains("Bad access to protected data in putfield")) { | ||
throw new RuntimeException("wrong exception: " + e.getMessage()); | ||
} | ||
} | ||
} | ||
} |
56 changes: 56 additions & 0 deletions
56
test/hotspot/jtreg/runtime/verifier/putfieldProtected.jasm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
// This .jasm file is needed for this test to ensure that the illegal protected | ||
// access is done at runtime. Otherwise, javac would detect and complain about | ||
// the illegal access | ||
super public class another/SuperC version 51:0 { | ||
protected Field f:I; | ||
|
||
public Method "<init>":"()V" stack 1 locals 1 { | ||
aload_0; | ||
invokespecial Method java/lang/Object."<init>":"()V"; | ||
return; | ||
} | ||
} // end Class another/SuperC | ||
|
||
|
||
super public class other/putfieldProtected extends another/SuperC version 51:0 { | ||
|
||
public Method "<init>":"()V" stack 1 locals 1 { | ||
aload_0; | ||
invokespecial Method another/SuperC."<init>":"()V"; | ||
return; | ||
} | ||
|
||
public static Method run:"()Z" stack 2 locals 2 { | ||
new class another/SuperC; | ||
dup; | ||
invokespecial Method another/SuperC."<init>":"()V"; | ||
iconst_1; | ||
putfield Field another/SuperC.f:"I"; | ||
iconst_1; | ||
ireturn; | ||
} | ||
|
||
} // end Class other/putfieldProtected |
99870b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues