8261404: Class.getReflectionFactory() is not thread-safe

Backport-of: 905b7639424a0fa80f81f734f6fdae1b5018a14a
openjdk · Mar 11, 2024 · a26445d · a26445d · openjdk-notifier · Mar 11, 2024
1 parent 7b7fbdf
commit a26445d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/java.base/share/classes/java/lang/Class.java b/src/java.base/share/classes/java/lang/Class.java
@@ -3506,12 +3506,13 @@ public boolean isEnum() {
 
     // Fetches the factory for reflective objects
     private static ReflectionFactory getReflectionFactory() {
-        if (reflectionFactory == null) {
-            reflectionFactory =
-                java.security.AccessController.doPrivileged
-                    (new ReflectionFactory.GetReflectionFactoryAction());
+        var factory = reflectionFactory;
+        if (factory != null) {
+            return factory;
         }
-        return reflectionFactory;
+        return reflectionFactory =
+                java.security.AccessController.doPrivileged
+                        (new ReflectionFactory.GetReflectionFactoryAction());
     }
     private static ReflectionFactory reflectionFactory;