Skip to content

Commit

Permalink
8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
Browse files Browse the repository at this point in the history 
Reviewed-by: mgronlun
Backport-of: a885aab696777c99c8c4c5d9a46afc5fe0a4fe47
  • Loading branch information
@jia-wei-tang @DamonFool
jia-wei-tang authored and DamonFool committed Mar 4, 2024
1 parent f6e6eef commit a4a5c7f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadGroup.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,12 @@ int JfrThreadGroupsHelper::populate_thread_group_hierarchy(const JavaThread* jt,
assert(current != NULL, "invariant");
assert(_thread_group_hierarchy != NULL, "invariant");

oop thread_oop = jt->threadObj();
if (thread_oop == NULL) {
return 0;
}
// immediate thread group
Handle thread_group_handle(current, java_lang_Thread::threadGroup(jt->threadObj()));
Handle thread_group_handle(current, java_lang_Thread::threadGroup(thread_oop));
if (thread_group_handle == NULL) {
return 0;
}
Expand Down

3 comments on commit a4a5c7f

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@jia-wei-tang
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk8u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on a4a5c7f Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jia-wei-tang the backport was successfully created on the branch backport-jia-wei-tang-a4a5c7fe in my personal fork of openjdk/jdk8u-dev. To create a pull request with this backport targeting openjdk/jdk8u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a4a5c7fe from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk8u-dev:

$ git fetch https://github.com/openjdk-bots/jdk8u-dev.git backport-jia-wei-tang-a4a5c7fe:backport-jia-wei-tang-a4a5c7fe
$ git checkout backport-jia-wei-tang-a4a5c7fe
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk8u-dev.git backport-jia-wei-tang-a4a5c7fe

⚠️ @jia-wei-tang You are not yet a collaborator in my fork openjdk-bots/jdk8u-dev. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.