Skip to content

Commit

Permalink
8320303: Allow PassFailJFrame to accept single window creator
Browse files Browse the repository at this point in the history 
Backport-of: 83ffc1ac94b8893532d8663b9058592f1714d337
  • Loading branch information
Andrew Lu committed Mar 7, 2024
1 parent bc14b9f commit b425dff
Showing 1 changed file with 146 additions and 27 deletions.
173 changes: 146 additions & 27 deletions test/jdk/java/awt/regtesthelpers/PassFailJFrame.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@
* .awaitAndCheck();
* }
*
* private static List<Window> createTestUI() {
* private static Window createTestUI() {
* JFrame testUI = new JFrame("Test UI");
* testUI.setSize(250, 150);
* return List.of(testUI);
* return testUI;
* }
* }
* }</pre>
Expand All @@ -108,6 +108,10 @@
* the provided {@code createTestUI} on the Event Dispatch Thread (EDT),
* and it will automatically position the test UI and make it visible.
* <p>
* The {@code Builder.testUI} methods accept interfaces which create one window
* or a list of windows if the test needs multiple windows,
* or directly a single window, an array of windows or a list of windows.
* <p>
* Alternatively, use one of the {@code PassFailJFrame} constructors to
* create an object, then create secondary test UI, register it
* with {@code PassFailJFrame}, position it and make it visible.
Expand Down Expand Up @@ -144,7 +148,7 @@
* <li>to enable screenshots.</li>
* </ul>
*/
public class PassFailJFrame {
public final class PassFailJFrame {

private static final String TITLE = "Test Instruction Frame";
private static final long TEST_TIMEOUT = 5;
Expand Down Expand Up @@ -263,12 +267,18 @@ private PassFailJFrame(Builder builder) throws InterruptedException,
this(builder.title, builder.instructions, builder.testTimeOut,
builder.rows, builder.columns, builder.screenCapture);

if (builder.windowCreator != null) {
if (builder.windowListCreator != null) {
invokeOnEDT(() ->
builder.testWindows = builder.windowCreator.createTestUI());
builder.testWindows = builder.windowListCreator.createTestUI());
if (builder.testWindows == null) {
throw new IllegalStateException("Window list creator returned null list");
}
}

if (builder.testWindows != null) {
if (builder.testWindows.isEmpty()) {
throw new IllegalStateException("Window list is empty");
}
addTestWindow(builder.testWindows);
builder.testWindows
.forEach(w -> w.addWindowListener(windowClosingHandler));
Expand All @@ -279,17 +289,15 @@ private PassFailJFrame(Builder builder) throws InterruptedException,
builder.positionWindows
.positionTestWindows(unmodifiableList(builder.testWindows),
builder.instructionUIHandler);

windowList.forEach(w -> w.setVisible(true));
});
} else if (builder.testWindows.size() == 1) {
Window window = builder.testWindows.get(0);
positionTestWindow(window, builder.position);
window.setVisible(true);
} else {
positionTestWindow(null, builder.position);
}
}
showAllWindows();
}

/**
Expand Down Expand Up @@ -370,7 +378,7 @@ private static void createUI(String title, String instructions,
frame.add(buttonsPanel, BorderLayout.SOUTH);
frame.pack();
frame.setLocationRelativeTo(null);
windowList.add(frame);
addTestWindow(frame);
}

private static JTextComponent configurePlainText(String instructions,
Expand Down Expand Up @@ -401,14 +409,27 @@ private static JTextComponent configureHTML(String instructions,


/**
* Creates one or more windows for test UI.
* Creates a test UI window.
*/
@FunctionalInterface
public interface WindowCreator {
/**
* Creates a window for test UI.
* This method is called by the framework on the EDT.
* @return a test UI window
*/
Window createTestUI();
}

/**
* Creates a list of test UI windows.
*/
@FunctionalInterface
public interface WindowListCreator {
/**
* Creates one or more windows for test UI.
* This method is called by the framework on the EDT.
* @return a list of windows.
* @return a list of test UI windows
*/
List<? extends Window> createTestUI();
}
Expand All @@ -424,8 +445,13 @@ public interface PositionWindows {
* the instruction UI frame was positioned on the screen.
* <p>
* The list of the test windows contains the windows
* that were passed to the framework via
* {@link Builder#testUI(WindowCreator) testUI} method.
* that were passed to the framework via the
* {@link Builder#testUI(Window...) testUI(Window...)} method or
* that were created with {@code WindowCreator}
* or {@code WindowListCreator} which were passed via
* {@link Builder#testUI(WindowCreator) testUI(WindowCreator)} or
* {@link Builder#testUI(WindowListCreator) testUI(WindowListCreator)}
* correspondingly.
*
* @param testWindows the list of test windows
* @param instructionUI information about the instruction frame
Expand Down Expand Up @@ -799,6 +825,29 @@ public static synchronized void addTestWindow(Collection<? extends Window> testW
windowList.addAll(testWindows);
}

/**
* Displays all the windows in {@code windowList}.
*
* @throws InterruptedException if the thread is interrupted while
* waiting for the event dispatch thread to finish running
* the {@link #showUI() showUI}
* @throws InvocationTargetException if an exception is thrown while
* the event dispatch thread executes {@code showUI}
*/
private static void showAllWindows()
throws InterruptedException, InvocationTargetException {
invokeOnEDT(PassFailJFrame::showUI);
}

/**
* Displays all the windows in {@code windowList}; it has to be called on
* the EDT &mdash; use {@link #showAllWindows() showAllWindows} to ensure it.
*/
private static synchronized void showUI() {
windowList.forEach(w -> w.setVisible(true));
}


/**
* Forcibly pass the test.
* <p>The sample usage:
Expand Down Expand Up @@ -841,7 +890,7 @@ public static final class Builder {
private boolean screenCapture;

private List<? extends Window> testWindows;
private WindowCreator windowCreator;
private WindowListCreator windowListCreator;
private PositionWindows positionWindows;
private InstructionUI instructionUIHandler;

Expand Down Expand Up @@ -877,39 +926,109 @@ public Builder screenCapture() {
return this;
}

/**
* Adds a {@code WindowCreator} which the framework will use
* to create the test UI window.
*
* @param windowCreator a {@code WindowCreator}
* to create the test UI window
* @return this builder
* @throws IllegalArgumentException if {@code windowCreator} is {@code null}
* @throws IllegalStateException if a window creator
* or a list of test windows is already set
*/
public Builder testUI(WindowCreator windowCreator) {
if (windowCreator == null) {
throw new IllegalArgumentException("The window creator can't be null");
}

checkWindowsLists();

this.windowListCreator = () -> List.of(windowCreator.createTestUI());
return this;
}

/**
* Adds a {@code WindowListCreator} which the framework will use
* to create a list of test UI windows.
*
* @param windowListCreator a {@code WindowListCreator}
* to create test UI windows
* @return this builder
* @throws IllegalArgumentException if {@code windowListCreator} is {@code null}
* @throws IllegalStateException if a window creator
* or a list of test windows is already set
*/
public Builder testUI(WindowListCreator windowListCreator) {
if (windowListCreator == null) {
throw new IllegalArgumentException("The window list creator can't be null");
}

checkWindowsLists();

this.windowListCreator = windowListCreator;
return this;
}

/**
* Adds an already created test UI window.
* The window is positioned and shown automatically.
*
* @param window a test UI window
* @return this builder
*/
public Builder testUI(Window window) {
return testUI(List.of(window));
}

/**
* Adds an array of already created test UI windows.
*
* @param windows an array of test UI windows
* @return this builder
*/
public Builder testUI(Window... windows) {
return testUI(List.of(windows));
}

public Builder testUI(List<Window> windows) {
/**
* Adds a list of already created test UI windows.
*
* @param windows a list of test UI windows
* @return this builder
* @throws IllegalArgumentException if {@code windows} is {@code null}
* or the list contains {@code null}
* @throws IllegalStateException if a window creator
* or a list of test windows is already set
*/
public Builder testUI(List<? extends Window> windows) {
if (windows == null) {
throw new IllegalArgumentException("The list of windows can't be null");
}
if (windows.stream()
.anyMatch(Objects::isNull)) {
throw new IllegalArgumentException("The windows list can't contain null");
throw new IllegalArgumentException("The list of windows can't contain null");
}

if (windowCreator != null) {
throw new IllegalStateException("windowCreator is already set");
}
checkWindowsLists();

this.testWindows = windows;
return this;
}

public Builder testUI(WindowCreator windowCreator) {
if (windowCreator == null) {
throw new IllegalArgumentException("The window creator can't be null");
/**
* Verifies the state of window list and window creator.
*
* @throws IllegalStateException if a windows list creator
* or a list of test windows is already set
*/
private void checkWindowsLists() {
if (windowListCreator != null) {
throw new IllegalStateException("Window list creator is already set");
}
if (testWindows != null) {
throw new IllegalStateException("testWindows are already set");
throw new IllegalStateException("The list of test windows is already set");
}
this.windowCreator = windowCreator;
return this;
}

public Builder positionTestUI(PositionWindows positionWindows) {
Expand Down Expand Up @@ -951,13 +1070,13 @@ private void validate() {
}

if (position == null
&& (testWindows != null || windowCreator != null)) {
&& (testWindows != null || windowListCreator != null)) {

position = Position.HORIZONTAL;
}

if (positionWindows != null) {
if (testWindows == null && windowCreator == null) {
if (testWindows == null && windowListCreator == null) {
throw new IllegalStateException("To position windows, "
+ "provide an a list of windows to the builder");
}
Expand Down

1 comment on commit b425dff

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

Please sign in to comment.