Skip to content

Commit d279487

Browse files
committed
8266318: Switch to macos prefix for macOS bundles
Reviewed-by: mdoerr, vkempik Backport-of: 096e9e5
1 parent 50e83c5 commit d279487

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

.github/workflows/submit.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,8 +1297,8 @@ jobs:
12971297
with:
12981298
name: transient_jdk-macos-x64${{ matrix.artifact }}_${{ needs.prerequisites.outputs.bundle_id }}
12991299
path: |
1300-
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}.tar.gz
1301-
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}.tar.gz
1300+
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}.tar.gz
1301+
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}.tar.gz
13021302
13031303
macos_aarch64_build:
13041304
name: macOS aarch64
@@ -1396,8 +1396,8 @@ jobs:
13961396
with:
13971397
name: transient_jdk-macos-aarch64${{ matrix.artifact }}_${{ needs.prerequisites.outputs.bundle_id }}
13981398
path: |
1399-
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-aarch64_bin${{ matrix.artifact }}.tar.gz
1400-
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-aarch64_bin-tests${{ matrix.artifact }}.tar.gz
1399+
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-aarch64_bin${{ matrix.artifact }}.tar.gz
1400+
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-aarch64_bin-tests${{ matrix.artifact }}.tar.gz
14011401
14021402
14031403
macos_x64_test:
@@ -1504,13 +1504,13 @@ jobs:
15041504

15051505
- name: Unpack jdk
15061506
run: |
1507-
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}"
1508-
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}"
1507+
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}"
1508+
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}"
15091509
15101510
- name: Unpack tests
15111511
run: |
1512-
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}"
1513-
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}"
1512+
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}"
1513+
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}"
15141514
15151515
- name: Install dependencies
15161516
run: brew install make
@@ -1520,14 +1520,14 @@ jobs:
15201520

15211521
- name: Find root of jdk image dir
15221522
run: |
1523-
imageroot=`find ${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }} -name release -type f`
1523+
imageroot=`find ${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }} -name release -type f`
15241524
echo "imageroot=`dirname ${imageroot}`" >> $GITHUB_ENV
15251525
15261526
- name: Run tests
15271527
id: run_tests
15281528
run: >
15291529
JDK_IMAGE_DIR=${{ env.imageroot }}
1530-
TEST_IMAGE_DIR=${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}
1530+
TEST_IMAGE_DIR=${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}
15311531
BOOT_JDK=${HOME}/bootjdk/${BOOT_JDK_VERSION}/Contents/Home
15321532
JT_HOME=${HOME}/jtreg
15331533
gmake run-test-prebuilt

make/autoconf/platform.m4

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2011, 2021, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -481,9 +481,11 @@ AC_DEFUN([PLATFORM_SETUP_LEGACY_VARS_HELPER],
481481
fi
482482
483483
# The new version string in JDK 9 also defined new naming of OS and ARCH for bundles
484-
# Macosx is osx and x86_64 is x64
484+
# The macOS bundle name was revised in JDK 17
485+
#
486+
# macosx is macos and x86_64 is x64
485487
if test "x$OPENJDK_$1_OS" = xmacosx; then
486-
OPENJDK_$1_OS_BUNDLE="osx"
488+
OPENJDK_$1_OS_BUNDLE="macos"
487489
else
488490
OPENJDK_$1_OS_BUNDLE="$OPENJDK_TARGET_OS"
489491
fi

make/conf/jib-profiles.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -598,11 +598,7 @@ var getJibProfilesProfiles = function (input, common, data) {
598598
profiles[bootcyclePrebuiltName].default_make_targets = [ "product-images" ];
599599
});
600600

601-
//
602601
// Define artifacts for profiles
603-
//
604-
// Macosx bundles are named osx
605-
// tar.gz.
606602
var artifactData = {
607603
"linux-x64": {
608604
platform: "linux-x64",
@@ -611,7 +607,7 @@ var getJibProfilesProfiles = function (input, common, data) {
611607
platform: "linux-x86",
612608
},
613609
"macosx-x64": {
614-
platform: "osx-x64",
610+
platform: "macos-x64",
615611
jdk_subdir: "jdk-" + data.version + ".jdk/Contents/Home",
616612
},
617613
"solaris-x64": {

0 commit comments

Comments
 (0)