Skip to content

Commit

Permalink
8282600: SSLSocketImpl should not use user_canceled workaround when n…
Browse files Browse the repository at this point in the history
…ot necessary

Backport-of: eef3c9605e2d75fc5724118fd0140b7844daa6e8
  • Loading branch information
zzambers authored and Paul Hohensee committed Mar 13, 2023
1 parent 479ddb6 commit e80528b
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,12 @@ private void duplexCloseOutput() throws IOException {
if (!conContext.protocolVersion.useTLS13PlusSpec()) {
hasCloseReceipt = true;
} else {
// Use a user_canceled alert for TLS 1.3 duplex close.
useUserCanceled = true;
// Do not use user_canceled workaround if the other side has
// already half-closed the connection
if (!conContext.isInboundClosed()) {
// Use a user_canceled alert for TLS 1.3 duplex close.
useUserCanceled = true;
}
}
} else if (conContext.handshakeContext != null) { // initial handshake
// Use user_canceled alert regardless the protocol versions.
Expand Down

3 comments on commit e80528b

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzambers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk8u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e80528b Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzambers the backport was successfully created on the branch zzambers-backport-e80528bf in my personal fork of openjdk/jdk8u-dev. To create a pull request with this backport targeting openjdk/jdk8u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e80528bf from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Zdenek Zambersky on 13 Mar 2023 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk8u-dev:

$ git fetch https://github.com/openjdk-bots/jdk8u-dev zzambers-backport-e80528bf:zzambers-backport-e80528bf
$ git checkout zzambers-backport-e80528bf
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk8u-dev zzambers-backport-e80528bf

Please sign in to comment.