Skip to content

8257148: Remove obsolete code in AWTView.m #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jun 2, 2021

Clean backport of 8257148.
This removes some dead code in AWTView.m which uses functions not available in arm64 version of JRS framework from macos


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/10.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c2af27beb09d7c1db8cb465759404bb9a633be80 8257148: Remove obsolete code in AWTView.m Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257148: Remove obsolete code in AWTView.m

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@VladimirKempik Since your change was applied there have been 3 commits pushed to the master branch:

  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Your commit was automatically rebased without conflicts.

Pushed as commit 006979a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8257148 branch June 4, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant