Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230808: Remove Access::equals() #100

Closed
wants to merge 1 commit into from
Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jul 6, 2021

This is the first patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next.

The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance.

Additional testing:

  • Linux x86_64 {release, fastdebug, slowdebug} builds
  • Linux x86_64 tier1, tier2 with Shenandoah, Parallel

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/100/head:pull/100
$ git checkout pull/100

Update a local copy of the PR:
$ git checkout pull/100
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 100

View PR using the GUI difftool:
$ git pr show -t 100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/100.diff

Reviewed-by: tschatzl, shade
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 6, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport cb50d3b4f3c3cb85a5312fdf20a3229b88302f53 8230808: Remove Access::equals() Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 6, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jul 27, 2021

Friendly reminder.

Loading

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230808: Remove Access::equals()

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • ... and 76 more: https://git.openjdk.java.net/jdk11u-dev/compare/d07f6d910bddcc4a9f1b6ddb8f24065c9be91340...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 3, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 4, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit 7751352.
Since your change was applied there have been 90 commits pushed to the master branch:

  • 35fcac6: 8168304: Make all of DependencyContext_test available in product mode
  • cf2cf25: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
  • 0c783b0: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • ... and 80 more: https://git.openjdk.java.net/jdk11u-dev/compare/d07f6d910bddcc4a9f1b6ddb8f24065c9be91340...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@shipilev Pushed as commit 7751352.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8230808 branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants