New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273655: content-types.properties files are missing some common types #1007
8273655: content-types.properties files are missing some common types #1007
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Bug now has |
/integrate |
@gnu-andrew Pushed as commit b6f59f5. |
Hi @gnu-andrew , |
Hi @gnu-andrew, our CI shows this, too. |
Hi @GoeLin , shall we problemlist the test ? |
I opened JDK-8285720 [11u 13u 15u] test/jdk/java/nio/file/Files/probeContentType/Basic.java fails after backport of 8273655 |
Why was this not picked up by pre-submit testing? Are we not running enough tests in GHA? |
Mailing list message from Lindenmaier, Goetz on jdk-updates-dev: Hi, It is a jdk tier2 test. Best regards, |
Ok, I just wondered why it was missed. The SKARA backport command makes things so easy, I guess I forgot to do due diligence. |
Finally submitted #1111 |
Hi all,
This pull request contains a backport of commit 65ed0a74 from the openjdk/jdk repository.
The commit being backported was authored by Julia Boes on 21 Sep 2021 and was reviewed by Brian Burkhalter and Daniel Fuchs.
This is a clean update of the OpenJDK mime types which has already been backported to 17u. The risk of extending the list of recognised types is low and will enable OpenJDK to correctly identify more file types.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1007/head:pull/1007
$ git checkout pull/1007
Update a local copy of the PR:
$ git checkout pull/1007
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1007/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1007
View PR using the GUI difftool:
$ git pr show -t 1007
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1007.diff