Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset" #1009

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 6, 2022

I backport this for parity with 11.0.16-oracle.

I had to change an instanceof operator to use Java 11 syntax.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1009/head:pull/1009
$ git checkout pull/1009

Update a local copy of the PR:
$ git checkout pull/1009
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1009

View PR using the GUI difftool:
$ git pr show -t 1009

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1009.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2047da7dccacb1adb7f811639a58b8fbe1aa3546 8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset" Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 6, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better readable than the original version :-)

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset"

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2022

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

Going to push as commit 67c4882.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6cc8d69: 8229210: [TESTBUG] Move gc stress tests from JFR directory tree to gc/stress
  • b6f59f5: 8273655: content-types.properties files are missing some common types
  • b9d0a03: 8283350: (tz) Update Timezone Data to 2022a

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2022
@openjdk openjdk bot closed this Apr 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@GoeLin Pushed as commit 67c4882.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8265297 branch April 7, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants