New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8213922: fix ctw stand-alone build #101
Conversation
… raised by the library itself
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
@RealCLanger, are you good with picking up the additional hunk for the unclean backport? |
yes, seems reasonable. |
Good, thanks. /integrate |
Going to push as commit c1deb0c. |
This allows CTW bundle to be built again. Note that it is unclean backport, and it includes the part of "8214917: CTW testlibrary shouldn't ignore errors raised by the library itself" -- which is already quite messy, and would be inconvenient to work in through the regular process.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/101/head:pull/101
$ git checkout pull/101
Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/101/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 101
View PR using the GUI difftool:
$ git pr show -t 101
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/101.diff