Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer #1018

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 7, 2022

Hi all,

This pull request contains a backport of JDK-8284389.

I had to resolve because the windows aarch64 build does not exist in jdk11u.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1018/head:pull/1018
$ git checkout pull/1018

Update a local copy of the PR:
$ git checkout pull/1018
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1018

View PR using the GUI difftool:
$ git pr show -t 1018

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1018.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61fcf2f67ff16bee92a5279e7bcacc79fc8f37ad 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you skipped the Windows aarch64 part. LGTM.

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2022
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2022

Going to push as commit 869b259.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b930441: 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX
  • 9b5d972: 8248876: LoadObject with bad base address created for exec file on linux
  • 4741ab5: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions
  • 2da50ce: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
  • b9a4153: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
  • 811cc9f: 8284573: [11u] ProblemList TestBubbleUpRef.java and TestGCOldWithCMS.java because of 8272195
  • e89b698: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
  • 7a02166: 8242312: use reproducible random in hotspot gc tests
  • e8fbaad: 8283641: Large value for CompileThresholdScaling causes assert
  • aeeab3d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2022
@openjdk openjdk bot closed this Apr 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2022
@RealCLanger RealCLanger deleted the RealCLanger-backport-61fcf2f6 branch April 11, 2022 15:37
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@RealCLanger Pushed as commit 869b259.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants