Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8218145: block_if_requested is not proper inlined due to size #102

Closed
wants to merge 1 commit into from

Conversation

@dchuyko
Copy link
Member

@dchuyko dchuyko commented Jul 6, 2021

This small optimization through a trivial refactoring is applicable to 11u. Original patch requires adjustment in a single place: there is initialize_serialize_page() in safepointMechanism.hpp because JDK-8213436 is not backported.

Testing: tier1, tier2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8218145: block_if_requested is not proper inlined due to size

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/102.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 6, 2021

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport f1fbd694788715532beca66b44f1afd83745e826 8218145: block_if_requested is not proper inlined due to size Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@dchuyko This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218145: block_if_requested is not proper inlined due to size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 02c0cf6: 8267424: CTW: C1 fails with "State must not be null"
  • bdf8568: 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call
  • 1d204c5: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • c1deb0c: 8213922: fix ctw stand-alone build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 6, 2021

Webrevs

Loading

@dchuyko
Copy link
Member Author

@dchuyko dchuyko commented Jul 8, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@dchuyko
Your change (at version 8ff1f5b) is now ready to be sponsored by a Committer.

Loading

@AlexanderScherbatiy
Copy link

@AlexanderScherbatiy AlexanderScherbatiy commented Jul 8, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit 2beb7e7.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 02c0cf6: 8267424: CTW: C1 fails with "State must not be null"
  • bdf8568: 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call
  • 1d204c5: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • c1deb0c: 8213922: fix ctw stand-alone build

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@AlexanderScherbatiy @dchuyko Pushed as commit 2beb7e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants