Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242312: use reproducible random in hotspot gc tests #1021

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 8, 2022

I backport this for parity with 11.0.16-oracle.

Resolved context, "8272783: Epsilon: Refactor tests to improve performance" already backported
test/hotspot/jtreg/gc/epsilon/TestByteArrays.java
test/hotspot/jtreg/gc/epsilon/TestElasticTLAB.java
test/hotspot/jtreg/gc/epsilon/TestElasticTLABDecay.java
test/hotspot/jtreg/gc/epsilon/TestRefArrays.java

I had to "implement" the change for this test. The test was removed with CMS
before the backported change was pushed.
test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithCMS.java

Copyright
test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData10.java

Context
test/hotspot/jtreg/gc/g1/humongousObjects/TestNoAllocationsInHRegions.java
test/hotspot/jtreg/gc/logging/TestUnifiedLoggingSwitchStress.java

"8256806: Shenandoah: optimize shenandoah/jni/TestPinnedGarbage.java test" was already
backported. I had to redo the change, differences wrt. random to head are gone now.
test/hotspot/jtreg/gc/shenandoah/jni/TestPinnedGarbage.java

Test at different location, patched manually
test/hotspot/jtreg/gc/stress/CriticalNativeStress.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242312: use reproducible random in hotspot gc tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1021/head:pull/1021
$ git checkout pull/1021

Update a local copy of the PR:
$ git checkout pull/1021
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1021

View PR using the GUI difftool:
$ git pr show -t 1021

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1021.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5efa545d487cbcdbee56e3afad925762c8688886 8242312: use reproducible random in hotspot gc tests Apr 8, 2022
@openjdk
Copy link

openjdk bot commented Apr 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 8, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description. LGTM. This backport should make other backports a bit easier.
Note: We don't build Shenandoah in 11u by default, so it may be missed by our testing.

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242312: use reproducible random in hotspot gc tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Apr 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 9, 2022

Going to push as commit 7a02166.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e8fbaad: 8283641: Large value for CompileThresholdScaling causes assert

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 9, 2022
@openjdk openjdk bot closed this Apr 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2022
@openjdk
Copy link

openjdk bot commented Apr 9, 2022

@GoeLin Pushed as commit 7a02166.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8242312 branch April 9, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants