Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8220658: Improve the readability of container information in the error log #1029

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 11, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8220658: Improve the readability of container information in the error log

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1029/head:pull/1029
$ git checkout pull/1029

Update a local copy of the PR:
$ git checkout pull/1029
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1029

View PR using the GUI difftool:
$ git pr show -t 1029

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1029.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 11, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2c4b9e0778e170a17b04217bee66bb6c4fb18c0c 8220658: Improve the readability of container information in the error log Apr 11, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 11, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8220658: Improve the readability of container information in the error log

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 11, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 11, 2022

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Apr 12, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2022

Going to push as commit 684fe80.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c38229f: 8284507: GHA: Only check test results if testing was not skipped
  • 6f0e5b1: 8284604: [11u] Update Boot JDK used in GHA to 11.0.14.1
  • 869b259: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
  • b930441: 8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 12, 2022
@openjdk openjdk bot closed this Apr 12, 2022
@openjdk openjdk bot removed ready rfr labels Apr 12, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2022

@MBaesken Pushed as commit 684fe80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant