Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281274: deal with ActiveProcessorCount in os::Linux::print_container_info #1031

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 12, 2022

Please review the backport of 8281274; it needs slight adjustment to go into jdk11u-dev.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281274: deal with ActiveProcessorCount in os::Linux::print_container_info

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1031/head:pull/1031
$ git checkout pull/1031

Update a local copy of the PR:
$ git checkout pull/1031
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1031

View PR using the GUI difftool:
$ git pr show -t 1031

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1031.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bb2e10ccea0c0b89b06ace034c99253e9999ec47 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281274: deal with ActiveProcessorCount in os::Linux::print_container_info

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2022
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit 1f20c8d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • bc28d8f: 8217233: Update build settings for AIX/xlc
  • 24fec25: 8203238: [TESTBUG] rewrite MemOptions shell test in Java
  • f5586d9: 8203239: [TESTBUG] remove vmTestbase/vm/gc/kind/parOld test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2022
@openjdk openjdk bot closed this Apr 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@MBaesken Pushed as commit 1f20c8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants