8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

[KostyaSha]

https://bugs.openjdk.java.net/browse/JDK-8211795

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1032/head:pull/1032
$ git checkout pull/1032

Update a local copy of the PR:
$ git checkout pull/1032
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1032

View PR using the GUI difftool:
$ git pr show -t 1032

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1032.diff

[bridgekeeper]

Hi @KostyaSha, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user KostyaSha" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@KostyaSha This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
• 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 987f7af: 8263718: unused-result warning happens at os_linux.cpp
• dbe5f17: 8285445: cannot open file "NUL:"
• 61b8c91: 8284622: Update versions of some Github Actions used in JDK workflow
• d9be932: 8285395: [JVMCI] [11u] Partial backport of JDK-8220623: InstalledCode
• 569ae08: 8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c
• 2037210: Merge
• 224e1a3: 8284920: Incorrect Token type causes XPath expression to return empty result
• 91d6550: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
• ... and 23 more: https://git.openjdk.java.net/jdk11u-dev/compare/24fec25451a71df8ccf2510227c6286fb8f792ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (0af1ba75)

[KostyaSha]

/integrate

[openjdk]

@KostyaSha
Your change (at version 0af1ba7) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

This repository requires to follow the process described here: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
(Especially step "6. Request and await approval for the fix".)
If you don't have JBS access, I suggest to provide the information here.

[KostyaSha]

If you don't have JBS access, I suggest to provide the information here.

The initial issue was found in jdk 11 and 12, but was fixed only in 12. I backported patch locally, built jdk and verified that our tool works fine. Btw zulu11 has no such issue, probably they backported this patch already. Would be cool to fix issuein openjdk 11 also.

PS sorry, first time ever i have issues with java

[TheRealMDoerr]

No problem. /integrate should be used after it got approved. I've updated the JBS issue. Let's wait for the maintainers to respond.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 29509b8.
Since your change was applied there have been 37 commits pushed to the master branch:

• b2ff90d: 8169004: Fix redundant @requires tags in tests
• d896abb: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
• 665f856: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
• 22f8e21: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
• bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
• 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 987f7af: 8263718: unused-result warning happens at os_linux.cpp
• dbe5f17: 8285445: cannot open file "NUL:"
• 61b8c91: 8284622: Update versions of some Github Actions used in JDK workflow
• d9be932: 8285395: [JVMCI] [11u] Partial backport of JDK-8220623: InstalledCode
• ... and 27 more: https://git.openjdk.java.net/jdk11u-dev/compare/24fec25451a71df8ccf2510227c6286fb8f792ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @KostyaSha Pushed as commit 29509b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.