Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key #1036

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Apr 19, 2022

Please review backport of JDK-8271199 to 11u
Backport is not clean because of changes introduced by JDK-8023980 and JDK-8172366. These changes are not related to functionality of JDK-8271199 so merge is trivial.
Also, there are simple changes related to instanceof pattern not implemented in JDK11.

sun/security/rsa jtreg and custom test with IAIK provider are passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1036/head:pull/1036
$ git checkout pull/1036

Update a local copy of the PR:
$ git checkout pull/1036
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1036

View PR using the GUI difftool:
$ git pr show -t 1036

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1036.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2022

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6232982b91cb2314e96ddbde3984836a810a556 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Apr 19, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 19, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2022

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 21, 2022
@alexeybakhtin
Copy link
Contributor Author

@alexeybakhtin alexeybakhtin commented Apr 27, 2022

/integrate

@openjdk openjdk bot added the sponsor label Apr 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2022

@alexeybakhtin
Your change (at version 17b2666) is now ready to be sponsored by a Committer.

@yan-too
Copy link

@yan-too yan-too commented Apr 27, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2022

Going to push as commit 7e4af05.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 27, 2022
@openjdk openjdk bot closed this Apr 27, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Apr 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2022

@yan-too @alexeybakhtin Pushed as commit 7e4af05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants