Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c #1037

Closed
wants to merge 1 commit into from
Closed

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c #1037

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 21, 2022

I would like to backport this small and low risk patch to fix a memory leak.

The original patch does not apply cleanly, due to context difference. The patch is small, applied manually.

Test:

  • jdk_awt on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1037/head:pull/1037
$ git checkout pull/1037

Update a local copy of the PR:
$ git checkout pull/1037
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1037

View PR using the GUI difftool:
$ git pr show -t 1037

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1037.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 36b3bbc53de074647ce04de890dc99bd5a2373e8 8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 21, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2022
@zhengyu123
Copy link
Contributor Author

Thanks, @TheRealMDoerr

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

Going to push as commit 569ae08.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@zhengyu123 Pushed as commit 569ae08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants