New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252648: Shenandoah: name gang tasks consistently #104
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Friendly reminder. @rkennke, @zhengyu123? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 64 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Got the push approval. /integrate |
Going to push as commit 8ec02f3.
Your commit was automatically rebased without conflicts. |
Unclean backport, because Shenandoah 11u does not have concurrent weak reference processing and concurrent class unloading.
Additional testing:
hotspot_gc_shenandoah
AbstractGangTask
uses in Shenandoah codeProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/104/head:pull/104
$ git checkout pull/104
Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/104/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 104
View PR using the GUI difftool:
$ git pr show -t 104
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/104.diff