8282008: Incorrect handling of quoted arguments in ProcessBuilder

[omikhaltsova]

I'd like to backport JDK-8282008 to jdk11u.
This bug was detected at first on jdk11u and the corresponding issue was opened with regards to it on jdk18u.
The original patch didn't apply cleanly due to slight differences in the imported packages' names and copyright.
Tested on Windows. All regular tests passed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8282008: Incorrect handling of quoted arguments in ProcessBuilder
• JDK-8282989: Incorrect handling of quoted arguments in ProcessBuilder on Windows (CSR)

Reviewers

• Vladimir Kempik (@VladimirKempik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1040/head:pull/1040
$ git checkout pull/1040

Update a local copy of the PR:
$ git checkout pull/1040
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1040

View PR using the GUI difftool:
$ git pr show -t 1040

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1040.diff

[bridgekeeper]

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (50d7f1c8)

[VladimirKempik]

lgtm

[openjdk]

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282008: Incorrect handling of quoted arguments in ProcessBuilder

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[omikhaltsova]

/integrate

[openjdk]

Going to push as commit c9d3291.
Since your change was applied there have been 65 commits pushed to the master branch:

• 316c514: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
• 8b0e5ec: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
• 2013819: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
• 9cb3797: 8283323: libharfbuzz optimization level results in extreme build times
• 844f03b: 8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows
• 7921cc1: 8286198: [linux] Fix process-memory information
• fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• c95c796: 8255787: Tag container tests that use cGroups with cgroups keyword
• 60588db: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• ... and 55 more: https://git.openjdk.java.net/jdk11u-dev/compare/7b8461119bc3dabf82bac3c73475cb9ce71ec970...master

Your commit was automatically rebased without conflicts.

[openjdk]

@omikhaltsova Pushed as commit c9d3291.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.