8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

[jbachorik]

Backport

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Reviewers

• Vladimir Kempik (@VladimirKempik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1044/head:pull/1044
$ git checkout pull/1044

Update a local copy of the PR:
$ git checkout pull/1044
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1044

View PR using the GUI difftool:
$ git pr show -t 1044

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1044.diff

[bridgekeeper]

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (d837603e)
• 00: Full (45f1c100)

[RealCLanger]

I removed jdk11u-fix-request from JBS issue for the time being. Please restore once the PR has been reviewed. Please also enable GHA for this. Thx.

[jbachorik]

Ok, I enabled the GHA for the PR source repo and now all the checks have passed.

Let's wait for some reviews then - the backport itself is pretty straight-forward with only minor merge conflicts in copyright, type cast and nullptr vs. NULL.

[jbachorik]

A gentle ping?

[VladimirKempik]

The backport looks good and almost a clean backport of original

[openjdk]

@jbachorik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• c95c796: 8255787: Tag container tests that use cGroups with cgroups keyword
• 60588db: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• 7b73cc2: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
• df88e3d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
• 32266ec: 8217017: [TESTBUG] Tests fail to compile after JDK-8216265
• bc18b07: 8284549: JFR: FieldTable leaks FieldInfoTable member
• 7d87cb7: 8284620: CodeBuffer may leak _overflow_arena
• 87e0662: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
• 0925ad1: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
• 2787100: 8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.
• ... and 21 more: https://git.openjdk.java.net/jdk11u-dev/compare/7e4af05023f26dfc898c07bc4e445fd246dc8418...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jbachorik]

/integrate

[openjdk]

Going to push as commit 4f29d1e.
Since your change was applied there have been 50 commits pushed to the master branch:

• 39fd29f: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
• 00ee3ff: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
• 364ed1d: 8234608: [TESTBUG] Fix G1 redefineClasses tests and a memory leak
• 281aeb9: 8264179: [TESTBUG] Some compiler tests fail when running without C2
• d05bd5f: 8163498: Many long-running security libs tests
• 0629ea6: 8209920: runtime/logging/RedefineClasses.java fail with OOME with ZGC
• fef9e84: 8209150: [TESTBUG] Add logging to verify JDK-8197901 to a different test
• 8f85dcf: 8285686: Update FreeType to 2.12.0
• 80c9f24: 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException
• 0056b9b: 8227389: Remove unsupported xlc16 compile options on aix
• ... and 40 more: https://git.openjdk.java.net/jdk11u-dev/compare/7e4af05023f26dfc898c07bc4e445fd246dc8418...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jbachorik Pushed as commit 4f29d1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.