8284458: CodeHeapState::aggregate() leaks blob_name

[zhengyu123]

I would like to backport this patch to 11u to fix a memory leak.

The original patch does not apply cleanly:

1. JDK-8275729 and JDK-8276429 that are not in 11u. However, the patch is small and conflicts are resolved manually.
2. nullptr language feature is not available in 11u, changed to NULL

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284458: CodeHeapState::aggregate() leaks blob_name

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1046/head:pull/1046
$ git checkout pull/1046

Update a local copy of the PR:
$ git checkout pull/1046
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1046

View PR using the GUI difftool:
$ git pr show -t 1046

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1046.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (140c8199)

[TheRealMDoerr]

Description mentions 17u instead of 11u. Change looks good.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284458: CodeHeapState::aggregate() leaks blob_name

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
• 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 987f7af: 8263718: unused-result warning happens at os_linux.cpp
• dbe5f17: 8285445: cannot open file "NUL:"
• 61b8c91: 8284622: Update versions of some Github Actions used in JDK workflow
• d9be932: 8285395: [JVMCI] [11u] Partial backport of JDK-8220623: InstalledCode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Description mentions 17u instead of 11u. Change looks good.
Fixed the description.

Thanks for the review, @TheRealMDoerr

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 234724c.
Since your change was applied there have been 20 commits pushed to the master branch:

• 73aea92: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
• 6480023: 8272167: AbsPathsInImage.java should skip *.dSYM directories
• 52aa769: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
• d279487: 8266318: Switch to macos prefix for macOS bundles
• 50e83c5: 8242538: java/security/SecureRandom/ThreadSafe.java failed on windows
• e11476c: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
• d14462f: 8234382: Test tools/javac/processing/model/testgetallmembers/Main.java using too small heap
• 43655b7: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
• 580a991: 8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp
• 29509b8: 8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
• ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/569ae08af53f6995013c21501bdfa67e20ba1a3e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 234724c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.