Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8169004: Fix redundant @requires tags in tests #1050

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 26, 2022

I backport this for parity with 11.0.16-oracle.

A whole bunch of trivial resolved due to context.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1050/head:pull/1050
$ git checkout pull/1050

Update a local copy of the PR:
$ git checkout pull/1050
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1050

View PR using the GUI difftool:
$ git pr show -t 1050

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1050.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc9941ae727b74e1b613fb977d2845ad04670577 8169004: Fix redundant @requires tags in tests Apr 26, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 26, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8169004: Fix redundant @requires tags in tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
  • 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 987f7af: 8263718: unused-result warning happens at os_linux.cpp
  • dbe5f17: 8285445: cannot open file "NUL:"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Apr 29, 2022

Thanks for the review!

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Apr 29, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2022

Going to push as commit b2ff90d.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d896abb: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • 665f856: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • 22f8e21: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
  • 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 987f7af: 8263718: unused-result warning happens at os_linux.cpp
  • dbe5f17: 8285445: cannot open file "NUL:"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready rfr labels Apr 29, 2022
@GoeLin GoeLin deleted the goetz_backport_8169004 branch Apr 29, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2022

@GoeLin Pushed as commit b2ff90d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants