Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp #1051

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 26, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1051/head:pull/1051
$ git checkout pull/1051

Update a local copy of the PR:
$ git checkout pull/1051
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1051

View PR using the GUI difftool:
$ git pr show -t 1051

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1051.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0050cd57761d0249d5668540a0bd19db96e42ee6 8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp

Remove INCLUDE_ALL_GCS conditionalization.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 580a991.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 29509b8: 8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
  • b2ff90d: 8169004: Fix redundant @requires tags in tests
  • d896abb: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • 665f856: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • 22f8e21: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify
  • 7e4af05: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 987f7af: 8263718: unused-result warning happens at os_linux.cpp
  • dbe5f17: 8285445: cannot open file "NUL:"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@GoeLin Pushed as commit 580a991.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant