Skip to content

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#1053

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8233551
Closed

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#1053
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8233551

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 27, 2022

I backport this for parity with 11.0.16-oracle.

I had to resolve the ProblemList. The change also fixes linux as noted in the duplicate JDK-8148958


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1053/head:pull/1053
$ git checkout pull/1053

Update a local copy of the PR:
$ git checkout pull/1053
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1053

View PR using the GUI difftool:
$ git pr show -t 1053

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1053.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit e11476c.
Since your change was applied there have been 9 commits pushed to the master branch:

  • d14462f: 8234382: Test tools/javac/processing/model/testgetallmembers/Main.java using too small heap
  • 43655b7: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
  • 580a991: 8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp
  • 29509b8: 8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
  • b2ff90d: 8169004: Fix redundant @requires tags in tests
  • d896abb: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • 665f856: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • 22f8e21: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • bf3438c: 8285591: [11] add signum checks in DSA.java engineVerify

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@GoeLin Pushed as commit e11476c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8233551 branch April 29, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants