Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284549: JFR: FieldTable leaks FieldInfoTable member #1055

Closed
wants to merge 1 commit into from
Closed

8284549: JFR: FieldTable leaks FieldInfoTable member #1055

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 27, 2022

A clean and low risk backport to fix a memory leak in jfr leak profiler.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284549: JFR: FieldTable leaks FieldInfoTable member

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1055/head:pull/1055
$ git checkout pull/1055

Update a local copy of the PR:
$ git checkout pull/1055
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1055

View PR using the GUI difftool:
$ git pr show -t 1055

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1055.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92f5e42696847de7e47e238412d2d541a11bccd7 8284549: JFR: FieldTable leaks FieldInfoTable member Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284549: JFR: FieldTable leaks FieldInfoTable member

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 28, 2022

Please check the Pre-submit test failures and state why you want to integrate anyways before labeling jdk11u-fix-request next time.

@zhengyu123
Copy link
Contributor Author

Please check the Pre-submit test failures and state why you want to integrate anyways before labeling jdk11u-fix-request next time.

GHA has been quite unstable lately, e.g. this particular failure is due to network connection.
Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1001::111). - connect (101: Network is unreachable) Could not connect to ppa.launchpad.net:80 (185.125.189.231), connection timed out [IP: 185.125.189.231 80]

Some of you other GHA have been stuck for quite a while, any guideline on how to deal with the situtations?

Thanks.

@GoeLin
Copy link
Member

GoeLin commented Apr 28, 2022

Hi,
to approve the backport it is fine for me if you state that the failure is unrelated to your fix and why, just as you did.
It should not go unchecked ... and if you don't tell me I can not know you checked it.
Thanks, Goetz

@zhengyu123
Copy link
Contributor Author

Hi, to approve the backport it is fine for me if you state that the failure is unrelated to your fix and why, just as you did. It should not go unchecked ... and if you don't tell me I can not know you checked it. Thanks, Goetz

I see, will do.

Thanks,

@zhengyu123
Copy link
Contributor Author

Hi, to approve the backport it is fine for me if you state that the failure is unrelated to your fix and why, just as you did. It should not go unchecked ... and if you don't tell me I can not know you checked it. Thanks, Goetz

Reran GHA, it is clean now.

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2022

Going to push as commit bc18b07.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 7d87cb7: 8284620: CodeBuffer may leak _overflow_arena
  • 87e0662: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • 0925ad1: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2787100: 8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.
  • ed29dca: 8262379: Add regression test for JDK-8257746
  • e8a5372: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • eea537d: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
  • 245e2f2: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9c10f3e: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • 234724c: 8284458: CodeHeapState::aggregate() leaks blob_name
  • ... and 15 more: https://git.openjdk.java.net/jdk11u-dev/compare/7e4af05023f26dfc898c07bc4e445fd246dc8418...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2022
@openjdk openjdk bot closed this May 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@zhengyu123 Pushed as commit bc18b07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants