Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 28, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1057/head:pull/1057
$ git checkout pull/1057

Update a local copy of the PR:
$ git checkout pull/1057
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1057

View PR using the GUI difftool:
$ git pr show -t 1057

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1057.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a49b1dc7042d8893d9ff2cdaeae05203dd18bba4 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available" Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 28, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2022

Webrevs

@VladimirKempik
Copy link

looks good, the backport is pretty clean, only different code formatting in jdk11u made it not so clean

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 52aa769.
Since your change was applied there have been 11 commits pushed to the master branch:

  • d279487: 8266318: Switch to macos prefix for macOS bundles
  • 50e83c5: 8242538: java/security/SecureRandom/ThreadSafe.java failed on windows
  • e11476c: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • d14462f: 8234382: Test tools/javac/processing/model/testgetallmembers/Main.java using too small heap
  • 43655b7: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
  • 580a991: 8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp
  • 29509b8: 8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
  • b2ff90d: 8169004: Fix redundant @requires tags in tests
  • d896abb: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • 665f856: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/bf3438c5dc993b96d089cabb5318bfc64a6904a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@GoeLin Pushed as commit 52aa769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8269772 branch April 29, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants