Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263407: SPARC64 detection fails on Athena (SPARC64-X) #106

Closed
wants to merge 2 commits into from

Conversation

@Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Jul 7, 2021

Backport of fix 8263407, details of implementation is in thread:
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-April/005999.html
Was built and run tier1 tests on Solaris machine


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263407: SPARC64 detection fails on Athena (SPARC64-X)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/106.diff

SPARC64 detection fails on Athena (SPARC64-X)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 7, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 7, 2021

Webrevs

Loading

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM. Thanks for contributing!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263407: SPARC64 detection fails on Athena (SPARC64-X)

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop
  • c44da65: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
  • 2beb7e7: 8218145: block_if_requested is not proper inlined due to size
  • 02c0cf6: 8267424: CTW: C1 fails with "State must not be null"
  • bdf8568: 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Jul 7, 2021
@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 8, 2021

@Larry-N This PR is not correctly recognized as backport. I think you have to change the PR title to "Backport 8263407".

Loading

@Larry-N Larry-N changed the title JDK-8263407 SPARC64 detection fails on Athena (SPARC64-X) Backport 8263407 Jul 8, 2021
@openjdk openjdk bot changed the title Backport 8263407 8263407: SPARC64 detection fails on Athena (SPARC64-X) Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

Loading

@openjdk openjdk bot added the backport label Jul 8, 2021
@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 9, 2021

Looks good now.

Loading

@Larry-N
Copy link
Contributor Author

@Larry-N Larry-N commented Jul 9, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@Larry-N
Your change (at version 88cc92c) is now ready to be sponsored by a Committer.

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 9, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit 591d769.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 509170c: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop
  • c44da65: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
  • 2beb7e7: 8218145: block_if_requested is not proper inlined due to size
  • 02c0cf6: 8267424: CTW: C1 fails with "State must not be null"
  • bdf8568: 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@RealCLanger @Larry-N Pushed as commit 591d769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants