Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests. #1061

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 29, 2022

I want to backport this because we see a failure on macOS 12 that will be fixed by this change.

I had to resolve a row of files:

Copyright:
test/hotspot/jtreg/gtest/GTestWrapper.java
test/jdk/sun/security/krb5/auto/KDC.java

Resolve @library command:
test/jdk/tools/launcher/ExecutionEnvironment.java

This test was added in 12 only and backported with all the fixes in 8238225.
test/jdk/tools/launcher/JliLaunchTest.java

Copyright, @library was added in backport of 8217340
test/jdk/tools/launcher/Test7029048.java

Test not in 11
test/jdk/vm/JniInvocationTest.java

This was also included in 8238225
test/lib/jdk/test/lib/Platform.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1061/head:pull/1061
$ git checkout pull/1061

Update a local copy of the PR:
$ git checkout pull/1061
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1061

View PR using the GUI difftool:
$ git pr show -t 1061

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1061.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 084f0b75bdb77fbfcc8d78583adebecddd26eab0 8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests. Apr 29, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 29, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thanks for the detailed description! LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.

Also cleanup some switches over OSes and use File.pathSeparator.

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 73aea92: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 6480023: 8272167: AbsPathsInImage.java should skip *.dSYM directories
  • 52aa769: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • d279487: 8266318: Switch to macos prefix for macOS bundles
  • 50e83c5: 8242538: java/security/SecureRandom/ThreadSafe.java failed on windows
  • e11476c: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • d14462f: 8234382: Test tools/javac/processing/model/testgetallmembers/Main.java using too small heap
  • 43655b7: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
  • 580a991: 8213440: Lingering INCLUDE_ALL_GCS in test_oopStorage_parperf.cpp
  • 29509b8: 8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/bf3438c5dc993b96d089cabb5318bfc64a6904a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented May 3, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2022

Going to push as commit 2787100.
Since your change was applied there have been 20 commits pushed to the master branch:

  • ed29dca: 8262379: Add regression test for JDK-8257746
  • e8a5372: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • eea537d: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
  • 245e2f2: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9c10f3e: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • 234724c: 8284458: CodeHeapState::aggregate() leaks blob_name
  • 73aea92: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 6480023: 8272167: AbsPathsInImage.java should skip *.dSYM directories
  • 52aa769: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • d279487: 8266318: Switch to macos prefix for macOS bundles
  • ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/bf3438c5dc993b96d089cabb5318bfc64a6904a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 3, 2022
@openjdk openjdk bot closed this May 3, 2022
@openjdk openjdk bot removed ready rfr labels May 3, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2022

@GoeLin Pushed as commit 2787100.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8216265 branch May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants