Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 29, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1062/head:pull/1062
$ git checkout pull/1062

Update a local copy of the PR:
$ git checkout pull/1062
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1062

View PR using the GUI difftool:
$ git pr show -t 1062

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1062.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bc12381105ef5ba14f99304a220817e97c9a99b5 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 2, 2022

Pre-submit failures:
one is fixed by 8283834, others are well nown failures surely unrelated to this docu change.

@GoeLin
Copy link
Member Author

GoeLin commented May 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit e8a5372.
Since your change was applied there have been 17 commits pushed to the master branch:

  • eea537d: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
  • 245e2f2: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9c10f3e: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • 234724c: 8284458: CodeHeapState::aggregate() leaks blob_name
  • 73aea92: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 6480023: 8272167: AbsPathsInImage.java should skip *.dSYM directories
  • 52aa769: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • d279487: 8266318: Switch to macos prefix for macOS bundles
  • 50e83c5: 8242538: java/security/SecureRandom/ThreadSafe.java failed on windows
  • e11476c: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/22f8e216eef4efc2685986067dee10e24301b6dc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@GoeLin Pushed as commit e8a5372.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant