-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284620: CodeBuffer may leak _overflow_arena #1068
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and can be considered as clean except Copyright year update.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks, @TheRealMDoerr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks, @vnkozlov |
/integrate |
Going to push as commit 7d87cb7.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 7d87cb7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport this patch to 11u for fixing a memory leak.
The original patch does not apply cleanly due to context difference. However, the patch is small, easily resolved manually.
Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1068/head:pull/1068
$ git checkout pull/1068
Update a local copy of the PR:
$ git checkout pull/1068
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1068/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1068
View PR using the GUI difftool:
$ git pr show -t 1068
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1068.diff