Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head #1073

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 6, 2022

Hi all,

This pull request contains a backport of commit c464f20f from the openjdk/jdk17u-dev repository to backport JDK-8285726.

The commit being backported was authored by Christoph Langer on 6 May 2022 and was reviewed by Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1073/head:pull/1073
$ git checkout pull/1073

Update a local copy of the PR:
$ git checkout pull/1073
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1073

View PR using the GUI difftool:
$ git pr show -t 1073

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1073.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c464f20f41ff8b6b7eb3f1357f9bd5fcd51b13cb 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 6, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

RealCLanger commented May 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2022

Going to push as commit 316c514.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 8b0e5ec: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • 2013819: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • 9cb3797: 8283323: libharfbuzz optimization level results in extreme build times
  • 844f03b: 8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows
  • 7921cc1: 8286198: [linux] Fix process-memory information
  • fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
  • c95c796: 8255787: Tag container tests that use cGroups with cgroups keyword
  • 60588db: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • 7b73cc2: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/32266eca29efd88982df199fee4da618caa7712c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 14, 2022
@openjdk openjdk bot closed this May 14, 2022
@openjdk openjdk bot removed ready rfr labels May 14, 2022
@openjdk
Copy link

openjdk bot commented May 14, 2022

@RealCLanger Pushed as commit 316c514.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant