Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255787: Tag container tests that use cGroups with cgroups keyword #1075

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 9, 2022

Backport to have the same keywords in 11 and 17ff.
I had to resolve one TEST.ROOT because there are more keywords in 11. Trivial.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255787: Tag container tests that use cGroups with cgroups keyword

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1075/head:pull/1075
$ git checkout pull/1075

Update a local copy of the PR:
$ git checkout pull/1075
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1075

View PR using the GUI difftool:
$ git pr show -t 1075

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1075.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4df8abc200568f09ac714437397dbc7f521015cf 8255787: Tag container tests that use cGroups with cgroups keyword May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 9, 2022
@GoeLin
Copy link
Member Author

GoeLin commented May 9, 2022

/clean

@openjdk openjdk bot added the clean label May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 9, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255787: Tag container tests that use cGroups with cgroups keyword

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 32266ec: 8217017: [TESTBUG] Tests fail to compile after JDK-8216265
  • bc18b07: 8284549: JFR: FieldTable leaks FieldInfoTable member
  • 7d87cb7: 8284620: CodeBuffer may leak _overflow_arena
  • 87e0662: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • 0925ad1: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2787100: 8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.
  • ed29dca: 8262379: Add regression test for JDK-8257746
  • e8a5372: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • eea537d: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
  • 245e2f2: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/73aea924dbb8f44c1e7630baf56210f859b9c6f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2022
@mlbridge
Copy link

mlbridge bot commented May 9, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 9, 2022

Pre-submit faiure: test failing frequently, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented May 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit c95c796.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 60588db: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • 7b73cc2: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use
  • df88e3d: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 32266ec: 8217017: [TESTBUG] Tests fail to compile after JDK-8216265
  • bc18b07: 8284549: JFR: FieldTable leaks FieldInfoTable member
  • 7d87cb7: 8284620: CodeBuffer may leak _overflow_arena
  • 87e0662: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • 0925ad1: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2787100: 8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests.
  • ed29dca: 8262379: Add regression test for JDK-8257746
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/73aea924dbb8f44c1e7630baf56210f859b9c6f0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@GoeLin Pushed as commit c95c796.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8255787 branch May 10, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant