8283323: libharfbuzz optimization level results in extreme build times

[backwaterred]

This PR backports changes to improve build performance with xlc.

It appears that the file was at make/modules/java.desktop/lib/Awt2dLibraries.gmk when this commit was made, but that file has since been moved to make/lib/Awt2dLibraries.gmk. This made the change show up as a conflict when I applied this backport using the Skara tools. I resolved the 'conflict' by copying the changes to the new path and marking the previous path as removed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8283323: libharfbuzz optimization level results in extreme build times

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1077/head:pull/1077
$ git checkout pull/1077

Update a local copy of the PR:
$ git checkout pull/1077
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1077

View PR using the GUI difftool:
$ git pr show -t 1077

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1077.diff

[bridgekeeper]

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (dd7aa203)
• 00: Full (4905d538)

[TheRealMDoerr]

You have missed the empty line deletion from the original change. Backports should be as clean and complete as possible. Besides that, LGTM. Note that I have created a clean backport PR for 17u-dev which should be done first: openjdk/jdk17u-dev#392

[backwaterred]

You have missed the empty line deletion from the original change. Backports should be as clean and complete as possible.

I appreciate the attention to detail, and have made this change.

Besides that, LGTM. Note that I have created a clean backport PR for 17u-dev which should be done first: openjdk/jdk17u-dev#392

Thanks for opening the change for jdk17, does jdk18 require a backport as well?

[TheRealMDoerr]

LGTM. Thanks! Would be nice to have in 18u, too, yes. But we don't require it in non-LTS releases.

[openjdk]

@backwaterred This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283323: libharfbuzz optimization level results in extreme build times

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 844f03b: 8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows
• 7921cc1: 8286198: [linux] Fix process-memory information
• fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• c95c796: 8255787: Tag container tests that use cGroups with cgroups keyword

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[backwaterred]

/integrate

[openjdk]

@backwaterred
Your change (at version dd7aa20) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 9cb3797.
Since your change was applied there have been 5 commits pushed to the master branch:

• 844f03b: 8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows
• 7921cc1: 8286198: [linux] Fix process-memory information
• fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• c95c796: 8255787: Tag container tests that use cGroups with cgroups keyword

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @backwaterred Pushed as commit 9cb3797.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.