JDK-8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows

[MBaesken]

The Visual Studio compilers (checked VS2013 and VS2017) do not know this flag, output is
cl : Command line warning D9002 : ignoring unknown option '-std=c+11'

So the flag should be avoided on Windows.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1081/head:pull/1081
$ git checkout pull/1081

Update a local copy of the PR:
$ git checkout pull/1081
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1081

View PR using the GUI difftool:
$ git pr show -t 1081

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1081.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (a066d116)

[TheRealMDoerr]

Shouldn't -std:c++11 be used on Windows?

[MBaesken]

Shouldn't -std:c++11 be used on Windows?

This gives pretty much the same warning
cl : Command line warning D9002 : ignoring unknown option '-std:c+11'

so it is unknown to both VS2013 and VS2017 (VS2017 however knows -std:c++14 but this is out of scope here).

[TheRealMDoerr]

Strange, but ok. Seems like c++11 is used by default on Windows somehow. Change makes sense to me. (JDK 17 and above use c++14 already, that's why this change is for 11u only.)

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286630: [11] avoid -std=c++11 CXX harfbuzz buildflag on Windows

Reviewed-by: mdoerr, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 7921cc1: 8286198: [linux] Fix process-memory information
• fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Looks good. Windows GHA error seems unrelated.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 844f03b.
Since your change was applied there have been 3 commits pushed to the master branch:

• 7921cc1: 8286198: [linux] Fix process-memory information
• fa37935: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
• e793096: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 844f03b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.