-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266490: Extend the OSContainer API to support the pids controller of cgroups #1089
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original change modifies Copyright of cgroupV2Subsystem_linux.cpp. Please add that before integrating. Otherwise, lgtm.
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi Martin, the Copyright was already changed by other backports, see so it does not need to changed in this PR: |
Ok. So, only adding the empty line would be nice. |
Done, added an empty line to os_linux.cpp . |
/integrate |
Going to push as commit 372af6a.
Your commit was automatically rebased without conflicts. |
The backport of 8266490 does not apply cleanly. Some copyright years need adjustment. The code in os_linux.cpp is slightly different in 11 compared to 17 and needs manual adjustment. TestPids.java needs change in the "run driver" line regarding whitebox (adjusted to jdk11 needs).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1089/head:pull/1089
$ git checkout pull/1089
Update a local copy of the PR:
$ git checkout pull/1089
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1089/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1089
View PR using the GUI difftool:
$ git pr show -t 1089
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1089.diff