Skip to content

8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"#1096

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-99bcec08
Closed

8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"#1096
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-99bcec08

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented May 18, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1096/head:pull/1096
$ git checkout pull/1096

Update a local copy of the PR:
$ git checkout pull/1096
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1096/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1096

View PR using the GUI difftool:
$ git pr show -t 1096

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1096.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 99bcec08b12fc747a0cb7be862cf71b627e05892 8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type" May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 18, 2022
@openjdk
Copy link

openjdk bot commented May 18, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"

GenerateOopMap::do_ldc must check for a DynamicInError as well as a Dynamic constant pool tag.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2022
@mlbridge
Copy link

mlbridge bot commented May 18, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit ab5b6a9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • cb1a537: 8133713: [macosx] Accessible JTables always reported as empty
  • 2b75da6: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • eb2d6b8: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 4f29d1e: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
  • 39fd29f: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@GoeLin Pushed as commit ab5b6a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant