Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders. #1098

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 19, 2022

Clean backport of JDK-7124293


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1098/head:pull/1098
$ git checkout pull/1098

Update a local copy of the PR:
$ git checkout pull/1098
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1098

View PR using the GUI difftool:
$ git pr show -t 1098

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1098.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6168452b9fe2b818cfe52a3807d90bcc849e068a 7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders. May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 19, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented May 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit 7265ae5.
Since your change was applied there have been 4 commits pushed to the master branch:

  • ab5b6a9: 8214275: CondyRepeatFailedResolution asserts "Dynamic constant has no fixed basic type"
  • cb1a537: 8133713: [macosx] Accessible JTables always reported as empty
  • 2b75da6: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
  • eb2d6b8: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@TheRealMDoerr Pushed as commit 7265ae5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant