Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements. #1099

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 19, 2022

Backport of JDK-7124301
Applies cleanly, but requires a trivial replacement:
JNF_COCOA_ENTER => JNI_COCOA_ENTER
JNF_COCOA_EXIT => JNI_COCOA_EXIT


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1099/head:pull/1099
$ git checkout pull/1099

Update a local copy of the PR:
$ git checkout pull/1099
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1099

View PR using the GUI difftool:
$ git pr show -t 1099

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1099.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/1097 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2146e52cfa2d9442ab80f4a0dea30c821e953657 7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements. May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think accessability is sufficiently important and the change is close enough
to 11 that we should backport it even if not thoroughly tested.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented May 19, 2022

Thanks for the review! This PR has 2 JBS issues, but Skara doesn't support that. I have to link that one manually after integration:
/issue remove JDK-7124298

@openjdk
Copy link

openjdk bot commented May 19, 2022

@TheRealMDoerr
Removing additional issue from issue list: 7124298.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1097 to master May 20, 2022 12:57
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 7124301_MacOS_TabGroup_VoiceOver
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented May 20, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements.

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 20, 2022
@TheRealMDoerr TheRealMDoerr force-pushed the 7124301_MacOS_TabGroup_VoiceOver branch from 8a7d2b5 to f71773e Compare May 20, 2022 13:09
@TheRealMDoerr
Copy link
Contributor Author

"Successfully rebased and updated refs/heads/7124301_MacOS_TabGroup_VoiceOver."
/integrate

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit 8533ba4.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 20, 2022
@TheRealMDoerr TheRealMDoerr deleted the 7124301_MacOS_TabGroup_VoiceOver branch May 20, 2022 13:14
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@TheRealMDoerr Pushed as commit 8533ba4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants