-
Notifications
You must be signed in to change notification settings - Fork 238
8287017: Bump update version for OpenJDK: jdk-11.0.17 #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
a62ec4e
to
728f151
Compare
Pre-submit failure: SuspendAtExit.java This test fails every once in a while, unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't judge if "ea" should be set. It's not done in 17u-dev: make/conf/version-numbers.conf:DEFAULT_PROMOTED_VERSION_PRE=
. Does this make sense? Besides this, LGTM.
Hi, in 17, there is an extra change to set ea. See description above. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 25ac222.
Your commit was automatically rebased without conflicts. |
The necessary version change.
To be pushed on June 1st after tag jdk-11.0.17+0
This includes adding ea as asked in JDK-8283911
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1100/head:pull/1100
$ git checkout pull/1100
Update a local copy of the PR:
$ git checkout pull/1100
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1100/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1100
View PR using the GUI difftool:
$ git pr show -t 1100
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1100.diff