Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287017: Bump update version for OpenJDK: jdk-11.0.17 #1100

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 19, 2022

The necessary version change.
To be pushed on June 1st after tag jdk-11.0.17+0

This includes adding ea as asked in JDK-8283911


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287017: Bump update version for OpenJDK: jdk-11.0.17

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/1100/head:pull/1100
$ git checkout pull/1100

Update a local copy of the PR:
$ git checkout pull/1100
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/1100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1100

View PR using the GUI difftool:
$ git pr show -t 1100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/1100.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 20, 2022

Pre-submit failure: SuspendAtExit.java This test fails every once in a while, unrelated.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't judge if "ea" should be set. It's not done in 17u-dev: make/conf/version-numbers.conf:DEFAULT_PROMOTED_VERSION_PRE=. Does this make sense? Besides this, LGTM.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 1, 2022

Hi, in 17, there is an extra change to set ea. See description above.

@openjdk
Copy link

openjdk bot commented Jun 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287017: Bump update version for OpenJDK: jdk-11.0.17

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 1c93a6e: 8285720: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails to compile after backport of 8273655
  • 7b58ca2: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 27d4c1e: 8287362: FieldAccessWatch testcase failed on AIX platform
  • de59d51: 8285397: JNI exception pending in CUPSfuncs.c:250
  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 22fc6ce: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • 69bdf9b: 8222799: java.beans.Introspector uses an obsolete methods cache
  • d71a543: 8287119: Add Distrust.java to ProblemList
  • b2c51c4: 8139046: Compiler Control: IGVPrintLevel directive should set PrintIdealGraph
  • ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/00ee3ff7f311f608e1556b19ebc8ea9a81491c59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 1, 2022

Going to push as commit 25ac222.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 1c93a6e: 8285720: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails to compile after backport of 8273655
  • 7b58ca2: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 27d4c1e: 8287362: FieldAccessWatch testcase failed on AIX platform
  • de59d51: 8285397: JNI exception pending in CUPSfuncs.c:250
  • 370730f: 8181571: printing to CUPS fails on mac sandbox app
  • 6faebb1: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 22fc6ce: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • 69bdf9b: 8222799: java.beans.Introspector uses an obsolete methods cache
  • d71a543: 8287119: Add Distrust.java to ProblemList
  • b2c51c4: 8139046: Compiler Control: IGVPrintLevel directive should set PrintIdealGraph
  • ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/00ee3ff7f311f608e1556b19ebc8ea9a81491c59...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 1, 2022
@openjdk openjdk bot closed this Jun 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 1, 2022
@openjdk
Copy link

openjdk bot commented Jun 1, 2022

@GoeLin Pushed as commit 25ac222.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_version_11_0_17 branch June 3, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants